Run tests on PHP 8.5 and update test environment #179
Merged
+23
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds PHP 8.5 support to the test environment and updates dependencies to ensure compatibility with the latest PHP version.
Changes:
- Added PHP 8.5 to the CI test matrix for both PHPUnit and PHPStan jobs
- Updated GitHub Actions checkout action from v4 to v6
- Updated React dependencies (event-loop, promise, socket) to newer minor versions
- Updated PHPStan to version 1.12.32
- Wrapped
ReflectionProperty::setAccessible()calls in version checks to avoid calling it on PHP 8.1+ where it's no longer needed
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Added PHP 8.5 to test matrix and updated actions/checkout to v6 |
| composer.json | Updated React dependencies and PHPStan to newer versions |
| tests/RedisClientTest.php | Added PHP version checks around setAccessible() calls to support PHP 8.1+ where the method is unnecessary |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #164, reactphp/socket#325, reactphp/promise#264, reactphp/event-loop#282, and clue/framework-x#297